Open
Conversation
BastianLedererIcinga
changed the base branch from
main
to
8.4/8.5-compatibility
Jan-Schuppik
reviewed
Dec 9, 2025
Jan-Schuppik
reviewed
Dec 9, 2025
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
a48b99b to
7d98bbe
Compare
Jan-Schuppik
previously approved these changes
Dec 10, 2025
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
7d98bbe to
e194919
Compare
sukhwinder33445
requested changes
Dec 11, 2025
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
87bf2cd to
a83714b
Compare
sukhwinder33445
previously approved these changes
Dec 11, 2025
BastianLedererIcinga
force-pushed
the
8.4/8.5-compatibility
branch
3 times, most recently
from
40c7f0b to
be36f28
Compare
lippserd
dismissed stale reviews from sukhwinder33445 and Jan-Schuppik
The base branch was changed.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
a83714b to
1538b72
Compare
sukhwinder33445
previously approved these changes
Jan 13, 2026
lippserd
requested changes
Jan 15, 2026
src/Query.php
Outdated
| @@ -704,7 +700,7 @@ public function peekAhead($peekAhead = true) | |||
| * | |||
| * @return \Generator | |||
Member
There was a problem hiding this comment.
You can simplify this to Generator.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
6a3071e to
45aa085
Compare
Contributor
There was a problem hiding this comment.
- I think we can define return types for
PersistBehavior|RetrieveBehaviorinterfaces, as they are not overridden by any other module. - Please use
[...]instead oflist() - Please import the class instead of using qualifier in
PropertiesWithDefaults (line 10-11). - Please remove the unused variable
$errinMillisecondTimestamp.
Note for myself:
The following classes and interfaces have not yet been modernized, as they are overridden by some modules (TBD):
Classes:
- PropertyBehavior
- Binary|BoolCast|MillisecondTimestamp
- Model
- UnionModel
- ResultSet
- Relation (partially)
- Query (Partially)
Interfaces:
- QueryAwareBehavior
- RewriteColumnBehavior
- RewriteFilterBehavior
5 tasks
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
ad48a0e to
25b8768
Compare
This was referenced Mar 2, 2026
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Looks good.
Please use backticks in the commits to highlight function, class, interface, etc. names.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
2 times, most recently
from
28bd4f2 to
1a6a329
Compare
BastianLedererIcinga
added a commit
to Icinga/icinga-notifications-web
that referenced
this pull request
Mar 4, 2026
Add types and missing return statements for implementations of: * `QueryAwarebehavior` * `RewriteFilterbehavior` To ensure compatibility with Icinga/ipl-orm#155. Add types to `ContactForm::isValidEent()` as required by Icinga/ipl-stdlib#68
BastianLedererIcinga
force-pushed
the
modernize-code
branch
4 times, most recently
from
e1d1c36 to
9734f88
Compare
Add strict type declarations to properties, function/method signatures, where types are unambiguous and no inheritance or interface contract is affected.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
2 times, most recently
from
59f2fe9 to
9b944e8
Compare
sukhwinder33445
previously approved these changes
Mar 5, 2026
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Looks good to me.
@lippserd, please take a look.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
9b944e8 to
2bcbda8
Compare
sukhwinder33445
previously approved these changes
Mar 5, 2026
Where functions are already adjusted and `throws` tags are missing they are added
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
2bcbda8 to
cee39f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selfwithstatic.TypeErrorinstead.Code that requires compatibility changes in modules is not modernized by this PR.